Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming Contract Agreements contain no Asset Information #336

Closed
2 tasks
richardtreier opened this issue May 15, 2023 · 1 comment
Closed
2 tasks

Consuming Contract Agreements contain no Asset Information #336

richardtreier opened this issue May 15, 2023 · 1 comment
Assignees
Labels
kind/enhancement New feature or request

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented May 15, 2023

Bug

Description

Right now we have no asset properties for consuming contract agreements in our Contract Agreement Endpoint.

The Core EDC team has said that this is not a bug and that they won't support us persisting any asset information during Contract Negotiation.

The data model still supports it, and currently does the right thing on the consumer side. This, however, is considered a bug by the core EDC team and might get removed in the near future.

We'd want to save both providing and consuming Contract Agreement's Asset information in the Contract Negotiation's persisted Contract Offer List.

Why Is the Feature Desired?

Our UI shows Asset Names in favor of Asset IDs. Asset properties are very central to the EDC data exchange, so we really need the information in the moment we try to consume data.

Solution Proposal and Work Breakdown

  • Implement an extension, that intercepts the right events at the right time, to then execute a request, to reliably (> 90%) fetch the asset properties, no matter how.
  • We want to fetch the asset information at the right time. The Contract Offer might disappear already mid-negotiation if some n-times-consumable policies are in place.
@richardtreier richardtreier added the kind/bug Something isn't working. The software does not behave as expected or specified. label May 15, 2023
@AbdullahMuk AbdullahMuk self-assigned this Nov 6, 2023
@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
@SebastianOpriel
Copy link
Member

Duplicate, close in favor of #427

@SebastianOpriel SebastianOpriel added kind/enhancement New feature or request and removed kind/bug Something isn't working. The software does not behave as expected or specified. clean-backlog requires backlog cleaning labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants