-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix app title logic #371
fix app title logic #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation-wise, that looks good.
I'm not sure though if this is okay from a business perspective, namely "MDS Portal" being removed from the title. This PR does more than is laid out in the connected issue.
Someone should clarify if this is okay.
MDS part is just a tiny bug after extracting it into separate PR, we can fix it very quick. |
@kamilczaja MDS is back in Titles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit e332338)
(cherry picked from commit e332338)
What issues does this PR close?
closes #237 Website title does not update in some scenarios
Unauthenticated
Onboarding (both organization and user)
Pending
Rejected
404 Page not found (page + title)
Logged In
Checklist