Skip to content

Commit

Permalink
refactor: rename attribute to better suit it's use-case
Browse files Browse the repository at this point in the history
  • Loading branch information
PaddseL committed Dec 10, 2024
1 parent 50fcecc commit 4331b9f
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data class ConnectorOverviewEntryDto(
@field:Schema(description = "Connector ID", requiredMode = Schema.RequiredMode.REQUIRED)
val id: String,
@field:Schema(description = "Organization Name", requiredMode = Schema.RequiredMode.REQUIRED)
val customerOrgName: String,
val organizationName: String,
@field:Schema(description = "Host Name", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
val hostName: String?,
@field:Schema(description = "Type", requiredMode = Schema.RequiredMode.REQUIRED)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class ConnectorManagementApiService(
val connectorDtos = connectors.map {
ConnectorOverviewEntryDto(
id = it.connectorId,
customerOrgName = orgNames[it.organizationId] ?: "",
organizationName = orgNames[it.organizationId] ?: "",
hostName = if (it.type == ConnectorType.CAAS) "sovity GmbH" else orgNames[it.providerOrganizationId] ?: "",
type = it.type.toDto(),
environment = deploymentEnvironmentDtoService.findByIdOrThrow(it.environment),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ class ConnectorManagementApiServiceTest {

result.connectors.forEachIndexed { i, connector ->
assertThat(connector.id).isEqualTo(dummyDevConnectorId(0, i))
assertThat(connector.customerOrgName).isEqualTo(dummyDevOrganizationName(0))
assertThat(connector.organizationName).isEqualTo(dummyDevOrganizationName(0))
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export const getListOfConnectorsForTable = (
).map((c) => {
return {
id: c.connectorId,
customerOrgName: c.organizationName,
organizationName: c.organizationName,
hostOrganizationName: c.hostOrganizationName,
type: c.type,
environment: c.environment,
Expand Down Expand Up @@ -196,7 +196,7 @@ export const getListOfOwnConnectorsForTable = (): ConnectorOverviewResult => {
).map((c) => {
return {
id: c.connectorId,
customerOrgName: c.organizationName,
organizationName: c.organizationName,
hostOrganizationName: c.hostOrganizationName,
type: c.type,
environment: c.environment,
Expand All @@ -222,7 +222,7 @@ export const getListOfAllConnectorsForTable = (): ConnectorOverviewResult => {
connectors: TEST_CONNECTORS.map((c) => {
return {
id: c.connectorId,
customerOrgName: c.organizationName,
organizationName: c.organizationName,
hostOrganizationName: c.hostOrganizationName,
type: c.type,
environment: c.environment,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
</td>
<td
class="py-8 text-sm font-medium whitespace-nowrap text-gray-700">
{{ connector.customerOrgName }}
{{ connector.organizationName }}
</td>
<td class="py-8 text-sm whitespace-nowrap text-gray-700">
{{ connector.hostName }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import {Subject, interval} from 'rxjs';
import {takeUntil} from 'rxjs/operators';
import {Store} from '@ngxs/store';
import {
ConnectorOverviewEntryDto,
ConnectorTypeDto,
ProvidedConnectorOverviewEntryDto,
UserRoleDto,
} from '@sovity.de/authority-portal-client';
import {GlobalStateUtils} from 'src/app/core/global-state/global-state-utils';
Expand Down Expand Up @@ -187,7 +187,7 @@ export class SpConnectorListPageComponent implements OnInit, OnDestroy {
this.slideOverService.slideOverReset();
}

openDetailPage(connector: ConnectorOverviewEntryDto) {
openDetailPage(connector: ProvidedConnectorOverviewEntryDto) {
this.slideOverConfig = {
childComponentInput: {
id: connector.id,
Expand Down

0 comments on commit 4331b9f

Please sign in to comment.