Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect safe navigation operator as a method call #71

Merged
merged 1 commit into from
May 16, 2020
Merged

Detect safe navigation operator as a method call #71

merged 1 commit into from
May 16, 2020

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jan 15, 2020

Close #70

Querly will detect a method call with a safe navigation operator as a method call.

Currently Querly ignores safe navigation operator. So if we use foo.bar pattern, it only matches foo.bar Ruby code, but does not match foo&.bar.
This pull request will fix the problem.

I think it is useful. When I'd like to find all foo method call, it includes x&.foo also.

soutaro
soutaro approved these changes May 16, 2020
View reviewed changes
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🍰

@soutaro soutaro merged commit 99a0012 into soutaro:master May 16, 2020
@pocke pocke deleted the csend branch May 16, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect csend node as method call
2 participants
@pocke @soutaro