Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirlcleci 2.0 #31

Merged
merged 23 commits into from
Oct 18, 2019
Merged

Cirlcleci 2.0 #31

merged 23 commits into from
Oct 18, 2019

Conversation

xorima
Copy link
Contributor

@xorima xorima commented May 21, 2019

Description

Use orb 2.0

Issues Resolved

[List any existing issues this PR resolves]

Check List

kitchen.dokken.yml Outdated Show resolved Hide resolved
kitchen.dokken.yml Outdated Show resolved Hide resolved
kitchen.dokken.yml Outdated Show resolved Hide resolved
kitchen.yml Outdated Show resolved Hide resolved
@xorima
Copy link
Contributor Author

xorima commented May 23, 2019

So the problem here is it no longer compiles on debian, and the commands do not seem to throw correctly so it is invisible to us, @damacus what are your thoughts here? I'm tempted to drop debian but that feels like a hack

@simonwgill
Copy link
Contributor

simonwgill commented Jun 25, 2019

So the problem here is it no longer compiles on debian, and the commands do not seem to throw correctly so it is invisible to us, @damacus what are your thoughts here? I'm tempted to drop debian but that feels like a hack

The compile step failure is because the open-appid feature needs LuaJIT support which is not available. That probably should be disabled for now (configure --disable-open-appid), and the tests pass in that case.

In the long run, using the shortcut format for the execute compile "configure && make && make install && ldconfig" does allow for failures in that process to stop the cookbook.

On a side note, the ln and copy commands probably should be resources in their own right instead of execute to allow the cookbook to recover certain changes. Interestingly, the presence of the source archive is used to determine if the source should be compiled rather than a signal from the environment.

Updated compile.rb from my over-complicated branch

@xorima
Copy link
Contributor Author

xorima commented Jun 25, 2019

@simonwgill Can you issue a pr into this branch so we can get this working, unfortunately my knowledge of compiling is non-existent so your help would be greatly appreciated!

@PowerSchill PowerSchill requested a review from a team October 15, 2019 01:00
@xorima
Copy link
Contributor Author

xorima commented Oct 17, 2019

@PowerSchill any chance you can resolve that last error on ubuntu please? :)

@PowerSchill
Copy link
Contributor

@PowerSchill any chance you can resolve that last error on ubuntu please? :)

How do you like that? Honestly I didn't do anything but it ran successfully locally so I just reran the workflow.

@JohnRoesler JohnRoesler merged commit ab54e7f into master Oct 18, 2019
@github-actions github-actions bot deleted the circleci2.0 branch October 18, 2019 12:57
@lock
Copy link

lock bot commented Nov 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants