-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirlcleci 2.0 #31
Cirlcleci 2.0 #31
Conversation
So the problem here is it no longer compiles on debian, and the commands do not seem to throw correctly so it is invisible to us, @damacus what are your thoughts here? I'm tempted to drop debian but that feels like a hack |
The compile step failure is because the open-appid feature needs LuaJIT support which is not available. That probably should be disabled for now (configure --disable-open-appid), and the tests pass in that case. In the long run, using the shortcut format for the execute compile "configure && make && make install && ldconfig" does allow for failures in that process to stop the cookbook. On a side note, the ln and copy commands probably should be resources in their own right instead of execute to allow the cookbook to recover certain changes. Interestingly, the presence of the source archive is used to determine if the source should be compiled rather than a signal from the environment. Updated compile.rb from my over-complicated branch |
@simonwgill Can you issue a pr into this branch so we can get this working, unfortunately my knowledge of compiling is non-existent so your help would be greatly appreciated! |
Split to capture status results from compile steps
@PowerSchill any chance you can resolve that last error on ubuntu please? :) |
How do you like that? Honestly I didn't do anything but it ran successfully locally so I just reran the workflow. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Use orb 2.0
Issues Resolved
[List any existing issues this PR resolves]
Check List