Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export resource for Chef 12.5.1 compatibility #67

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

davidgiesberg
Copy link
Contributor

Compilation fails under Chef 12.5.1 (worked fine in 12.3.1)

================================================================================
       Recipe Compile Error in /tmp/kitchen/cookbooks/nfs_test/recipes/issue46.rb
       ================================================================================

       Chef::Exceptions::ValidationFailed

       Option network must be one of: required!  You passed "127.0.0.1".

       Cookbook Trace:
       ---------------
         /tmp/kitchen/cookbooks/nfs_test/recipes/issue46.rb:11:in `block in from_file'

This fix works for me

@martinb3
Copy link

👍 we're also seeing this.

@joerocklin
Copy link
Contributor

Running through some kitchen tests to make sure all looks good there (just to make sure), and then will merge it in (unless @atomic-penguin has an objection).

@joerocklin
Copy link
Contributor

All looks good with my tests - I wanted to make sure it didn't break anything with clients prior to 12.5 (I checked 12.4 and 11.18). I'll get the rest of the pieces together and bump the version. But I can't upload to the chef supermarket, so we'll have to wait for @atomic-penguin for that.

joerocklin added a commit that referenced this pull request Oct 14, 2015
Fix `export` resource for Chef 12.5.1 compatibility
@joerocklin joerocklin merged commit 3e7baf7 into sous-chefs:master Oct 14, 2015
joerocklin added a commit to joerocklin/cookbook-nfs that referenced this pull request Oct 14, 2015
* @davidgiesberg - fixed an issue with chef-client 12.5 in sous-chefs#67
@joshzitting
Copy link

yes! good fix we need this asap! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants