Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop warning fixes #4

Merged
merged 1 commit into from
Mar 4, 2015
Merged

Rubocop warning fixes #4

merged 1 commit into from
Mar 4, 2015

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Mar 4, 2015

@fonsecas72
Copy link
Contributor

This does not seem to affect anything, Am I wrong?
But I would like to add consistency between projects.
For what I'm used to see, I would only change the vendor's igore to

 - 'vendor/**/*'

@guilhem
Copy link
Contributor Author

guilhem commented Mar 4, 2015

@fonsecas72 problems seems to appear here: https://travis-ci.org/redguide/locales/jobs/53025883

@fonsecas72
Copy link
Contributor

It looks like only the vendor's dir exclusion is deprecated and that's why I would not change the other files inclusions because I usually see file inclusion (edited) as they were.
I'de say, let's choose one way or another and apply it to all cookbooks.

@guilhem
Copy link
Contributor Author

guilhem commented Mar 4, 2015

@fonsecas72 include as it's done in this patch is cool for test-cookbooks that can be in test directory.
But it's obviously not a major things.

Let me know what @redguide/locales are thinking and I will change my commit :)

@guilhem
Copy link
Contributor Author

guilhem commented Mar 4, 2015

oh and also @fonsecas72 there is no problem to me if 2 teams of maintainers don't want same syntax or behavior.
What I only want is discussions, examples and contributions between each other :) (and I'm sure the better will won at the end by "success story" ;))

"big bang" changes have too many chances to fail and to freeze any new way of thinking ^^

@BarthV
Copy link
Contributor

BarthV commented Mar 4, 2015

Using test cookbooks can be very useful in the future, if we feel the need to add some QA/tests.
👍 for this PR syntax

@fonsecas72
Copy link
Contributor

Using test cookbooks can be very useful in the future

I don't know how this can become handy yet, so 👍 to learn. ;-)

guilhem added a commit that referenced this pull request Mar 4, 2015
@guilhem guilhem merged commit d9193de into master Mar 4, 2015
@guilhem guilhem deleted the rubocop-warning branch March 4, 2015 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants