Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plugin installation, bump to 1.0.4 #383

Closed
wants to merge 1 commit into from

Conversation

erulabs
Copy link

@erulabs erulabs commented Oct 16, 2015

Fixes #382

@erulabs
Copy link
Author

erulabs commented Oct 16, 2015

Note that I think this might only be broken for ES 2.0beta. It seems like "plugin -i" used to work. In ES2.0beta it's ONLY "plugin install" that works properly.

@martinb3 martinb3 self-assigned this Oct 16, 2015
@martinb3 martinb3 added this to the 2.0.0 release milestone Oct 16, 2015
@martinb3
Copy link
Contributor

Hi @erulabs! Could you try the 2.0.0_wip branch on this repo? I think it should already address this particular issue. Thanks!

@erulabs
Copy link
Author

erulabs commented Oct 22, 2015

Heya - the 2.0.0_wip branch looks great, thanks! However, it still fails to install any plugins - because "-install" is not a command :)

@martinb3
Copy link
Contributor

Hi @erulabs -- that part has been removed, and it should be running install, not -install: https://github.com/elastic/cookbook-elasticsearch/blob/2.0.0_wip/libraries/provider_plugin.rb#L44 Can you verify you're running that branch I'm linking to? Maybe needs a berks update to get a newer commit on the branch?

@chris-flite
Copy link

Thanks for this PR.
This fix would be great to have in a release on supermarket.
Working around by using execs to install plugins, looks funny.

@martinb3
Copy link
Contributor

@chris-flite Have you tried the 2.0.0_wip branch? This has already been fixed there and we've gotten only positive feedback so far.

@martinb3 martinb3 closed this in dc77bc5 Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants