Init script incorrectly creates data dirs

[jeffbyrnes]

On elasticsearch.in.sh.erb line 12, we simply convert the value of params[:DATA_DIR] to a string (see provider_configure.rb @ line 76 for the assignment). This results in one of two things:

1. A string-delimited set of paths, which mkdir interprets literally (so you might end up with a path like /mnt/dev0/elasticsearch/data,/mnt/dev1/elasticsearch/data
2. A string-y representation of your array (e.g., '["str1", "str2"]'), which bash does not like

It seems that the elasticsearch_configure LWRP and the service scripts for Debian & Ubuntu systems both create the data directories ES needs:

• https://github.com/elastic/cookbook-elasticsearch/blob/v2.2.1/templates/debian/initscript.erb#L146
• https://github.com/elastic/cookbook-elasticsearch/blob/v2.2.1/templates/ubuntu/initscript.erb#L146

I think the mkdir in the service scripts can be removed, which would also give them parity with how the other systems’ service scripts work.

[martinb3]

Hello, and thanks for catching this! We're actually using the exact init scripts provided by the deb/rpm packages shipped from Elastic. I'm going to report this upstream... it's clear the init scripts can't handle comma-delimited data directories.

[jeffbyrnes]

@martinb3 makes perfect sense.

[karmi]

Thanks for the fix, @dakrone!