Make config template configurable

[maikihde]

Hi,
it would would be really cool, if the template that creates the logging.yml (and maybe others) could be made configurable, so that an application cookbook could set attributes to override the template file and instead "plug" in it's own template. Similarly as it is done in the varnish cookbook:

template "#{node['varnish']['dir']}/#{node['varnish']['vcl_conf']}" do
  source node['varnish']['vcl_source']
  if node['varnish']['vcl_cookbook']
    cookbook node['varnish']['vcl_cookbook']
  end
...
end

Kind Regards,
Maik

[karmi]

Why not use the common “wrapper cookbook” approach instead? https://github.com/elasticsearch/cookbook-elasticsearch#customizing-the-cookbook.

I don't feel very well about having dozens of configurable node attributes in general...

[maikihde]

I prefer to use attributes in such a case, so you can override settings easier in the wrapper cookbook. I have done as described above, but it feels a bit dangerous, because if the name of that template resource changes, it is going to fail...

[karmi]

If the name of the template would change like that, I guess you'd have to check many other things :)

I don't think the goal should be "I don't care about cookbook" changes, but to facilitate configuration & customization. This is a goal I take seriously.

On 28. 10. 2013, at 13:13, maikihde [email protected] wrote:

I prefer to use attributes in such a case, so you can override settings easier in the wrapper cookbook. I have done as described above, but it feels a bit dangerous, because if the name of that template resource changes, it is going to fail...

—
Reply to this email directly or view it on GitHub.

[neovatar]

+1 for this feature request!

I also need to configure the logging in a way that I cannot do it with the provided template. While its possible to do it with resource manipulation like you describe in your documentation, it still feels a lot like monkey patching and not like using a library(-cookbook). Logging will probably be one of more heavily customized thinks in an specific environment, so an additional attribute maybe well justified.

If you consider adding this functionality, I can offer to work on it and send a pull request.

[karmi]

@maikihde @neovatar Agreed that it could help in some scenarios. Though, given the myriad of ways you can accomplish something in Chef, what is the exact usage pattern here? Can you elaborate?

1/ User uses this cookbook as is
2/ User has an application cookbook
3/ The application cookbook changes value of some node.elasticsearch.configuration_template attribute?
4/ The cookbook picks up this attribute?
5/ Where do you store the custom template? In the application cookbook?

[maikihde]

1/ yes, I try hard to not fork cookbooks if not absolutely neccessary
2/ definetely yes :)
3/ yes, it would change some attribute
4/ yes the library cookbook picks up the attribute and looks for
5/ the template (is) in the application cookbook

Hope this clears it up.

[karmi]

@maikihde Sorry, the issue slipped by. There's a discussion about something similar in #186 now, I think we should have this support for the brave people.

I'm no Lisp fanboi, but I shudder a bit when I think about the application cookbook changing the attribute of the elasticsearch cookbook :) I would really advice to research the "wrapper cookbook" pattern.

[karmi]

Hi, add some patch which should implement the feature, can you have a look? Thanks!

[maikihde]

Looks good for me, thanks!

Maik

---

Von: Karel Minarik [[email protected]]
Gesendet: Mittwoch, 18. Juni 2014 18:10
An: elasticsearch/cookbook-elasticsearch
Cc: Ihde, Maik
Betreff: Re: [cookbook-elasticsearch] Make config template configurable (#153)

Hi, add some patch which should implement the feature, can you have a look? Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/153#issuecomment-46457118.