Fixed dead service containers not being restarted on docker_container :run #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tduffield
pushed a commit
that referenced
this pull request
Nov 21, 2014
…service-when-container-down Fixed dead service containers not being restarted on docker_container :run
jperville
deleted the
container-action-run-restarts-service-when-container-down
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just stumbled on @jochenseeber 's #235 issue when investigating why some containers were not being restarted after running chef-client on my production server.
In short, when a container:
Then the next chef-run will leave my container down without trying to restart it.
This modest PR should easily fix the issue.