Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple bind_uris #24

Closed
jayofdoom opened this issue Nov 5, 2013 · 3 comments
Closed

Support multiple bind_uris #24

jayofdoom opened this issue Nov 5, 2013 · 3 comments

Comments

@jayofdoom
Copy link
Contributor

Currently, you can only specify one bind_uri. Docker supports specifying more than one.

I'll begin work on a PR to do this within a week or so if you'll accept it + this hasn't been fixed by then.

Thanks!

@bflad
Copy link
Contributor

bflad commented Nov 6, 2013

Seems reasonable since Docker allows for binding both a socket file and tcp URI. How were you thinking the implementation would look? I'd be tempted to just add a bind_socket (or similar) attribute that handles the -H for the socket file.

@jayofdoom
Copy link
Contributor Author

I was just going to implement the bind_uri as an array, actually. That way people can bind to whatever they want, as much as they want.

@bflad
Copy link
Contributor

bflad commented Nov 11, 2013

In 0.12.0 of the cookbook, I've added node['docker']['bind_socket'] with default of unix:///var/run/docker.sock and left node['docker']['bind_uri'] available to be overridden. It doesn't make sense (or works? haven't tested) to bind to more than one socket and one URI at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants