Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support amazon as a platform_family as per chef/ohai#971 #478

Merged
merged 4 commits into from
Apr 12, 2017

Conversation

svanzoest
Copy link
Contributor

@svanzoest svanzoest commented Apr 11, 2017

Description

With Chef 13 the amazon kitchen test fails entirely, because it is looking for platform_family of amazon instead of rhel and therefore all the platform specific code doesn't run.

This is tested against chef 13 and based on a review chef 12 should continue to work.

Issues Resolved

Related to #361

Check List

@svanzoest
Copy link
Contributor Author

Food critic FC024 seems to be failing as maybe Foodcritic/foodcritic#550 is not released yet?

@svanzoest svanzoest requested a review from tas50 April 11, 2017 23:18
@svanzoest svanzoest merged commit 214d71c into master Apr 12, 2017
svanzoest added a commit that referenced this pull request Apr 12, 2017
@svanzoest svanzoest deleted the amazon_platform branch April 12, 2017 01:12
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant