Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .conf extension for sites-available/* sites-enabled/* #315

Closed
hrak opened this issue Feb 12, 2015 · 4 comments
Closed

Missing .conf extension for sites-available/* sites-enabled/* #315

hrak opened this issue Feb 12, 2015 · 4 comments

Comments

@hrak
Copy link
Contributor

hrak commented Feb 12, 2015

In this bit of code, the cookbook wants to delete the default vhost config installed by the apache2 package

%w(default 000-default).each do |site|
  link "#{node['apache']['dir']}/sites-enabled/#{site}" do
    action :delete
  end

  file "#{node['apache']['dir']}/sites-available/#{site}" do
    action :delete
    backup false
  end
end

On Ubuntu 14.04 and Debian Sid, the files in sites-available/ and the links in sites-enabled/ have a .conf extension ('000-default.conf') so they are never removed.

@svanzoest
Copy link
Contributor

Thanks @hrak
There are a few different platforms, some with .conf, some without and I can easily see how we may have missed this.

@hrak
Copy link
Contributor Author

hrak commented Feb 13, 2015

#188 seems related, and also mentions 000-default.conf, but the fix applied in that bug report still does not cover the .conf extension. The only thing that sort of fixed #188 was this change:

+apache_site '000-default' do
+ enable node['apache']['default_site_enabled']
+end

that re-enables the never removed 000-default.conf (ignoring the 'sites-available/default.conf' that gets installed by the cookbook). This bit is now removed from the current version of the cookbook.

@svanzoest
Copy link
Contributor

I think my recent commit resolves this, can you confirm?

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants