Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: add --output-all-comparisons to manysearch, multisearch, and pairwise #544

Merged
merged 14 commits into from
Dec 19, 2024

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Dec 15, 2024

This PR adds -A/--output-all-comparisons to manysearch, multisearch, and pairwise. Updates documentation, adds tests, etc.

A few notes:

  • -t/--threshold is ignored when -A is provided.
  • manysearch against RocksDB will only output comparisons with some overlap; this is documented.

This PR also:

Fixes #542
Fixes #539
Fixes #533

TODO:

  • add tests

@ctb ctb changed the title WIP: add --output-all-comparisons to manysearch, multisearch, and pairwise MRG: add --output-all-comparisons to manysearch, multisearch, and pairwise Dec 15, 2024
@ctb
Copy link
Collaborator Author

ctb commented Dec 15, 2024

Ready for review & merge @bluegenes

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctb ctb merged commit a950309 into main Dec 19, 2024
3 checks passed
@ctb ctb deleted the output_all_comparisons branch December 19, 2024 22:47
@ctb ctb mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants