Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add initial test to block indexing identical files in the SBT. #945

Closed
wants to merge 3 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 15, 2020

Addresses behavior where same signature file can be inserted multiple times into an SBT.

Fixes #145, or will eventually :)

The main question here is, what is the appropriate behavior?

  • we could block and/or complain at the command line.
  • and/or we could raise an exception at the API level.

I think I'm in favor of both, since this is clearly invalid behavior. I'm not sure how to implement the latter, will look into it.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title [WIP] add initial test for indexing same files [WIP] add initial test to block indexing identical files in the SBT. Apr 15, 2020
@luizirber
Copy link
Member

Note: a duplicated MD5 doesn't mean it's the same signature (empty sigs will have same MD5, but different name/filename. Ref: #994

@ctb ctb closed this Aug 20, 2022
@ctb ctb deleted the fix/sbt_add_same branch August 20, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting file names when saving SBT
2 participants