Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a read-only IPFS client #557

Merged
merged 8 commits into from
Jan 28, 2019

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Oct 17, 2018

This brings in (or should be merged into) #456

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #557 into refactor/faster_indexing will increase coverage by 0.15%.
The diff coverage is 63.63%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           refactor/faster_indexing     #557      +/-   ##
============================================================
+ Coverage                     88.42%   88.58%   +0.15%     
============================================================
  Files                            27       27              
  Lines                          4329     4414      +85     
  Branches                         39       39              
============================================================
+ Hits                           3828     3910      +82     
- Misses                          501      504       +3
Impacted Files Coverage Δ
sourmash/__main__.py 96% <ø> (ø) ⬆️
sourmash/sbt.py 86.22% <100%> (+5.29%) ⬆️
sourmash/commands.py 85.66% <7.89%> (-3.43%) ⬇️
sourmash/sbt_storage.py 87.87% <90.9%> (+1.51%) ⬆️
sourmash/lca/command_index.py 90.74% <0%> (+0.44%) ⬆️
sourmash/lca/lca_utils.py 96.03% <0%> (+0.79%) ⬆️
sourmash/signature_json.py 96.87% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc43069...fda9a64. Read the comment docs.

@luizirber luizirber changed the base branch from master to refactor/faster_indexing January 28, 2019 22:34
@luizirber luizirber merged commit b7b9d51 into refactor/faster_indexing Jan 28, 2019
@luizirber luizirber deleted the feat/ipfs_gateways branch January 28, 2019 22:50
luizirber added a commit that referenced this pull request Jul 7, 2019
* start support for loading IPFS data without a local node

* start prepare command

* implement prepare cmd

* add sbt prepare test data

* more tests, fix migrate

* working on preloading

* add stub unload method

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant