Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix sig kmers #2856

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from
Open

WIP: Fix sig kmers #2856

wants to merge 4 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Nov 29, 2023

Fixes sig kmers to properly ignore bad DNA unless --check-sequence is provided; adds tests. Fixes #2842.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d6994a1) 86.23% compared to head (6dcc515) 29.74%.

Files Patch % Lines
src/sourmash/sig/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           latest    #2856       +/-   ##
===========================================
- Coverage   86.23%   29.74%   -56.50%     
===========================================
  Files         130      130               
  Lines       14756    14756               
  Branches     2622     2404      -218     
===========================================
- Hits        12725     4389     -8336     
- Misses       1731    10167     +8436     
+ Partials      300      200      -100     
Flag Coverage Δ
hypothesis-py 25.80% <50.00%> (ø)
python ?
rust 50.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb
Copy link
Contributor Author

ctb commented Sep 26, 2024

ref #3339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation for sourmash signature kmers is incorrect about exiting with bad kmers
1 participant