-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] fix docs building for pip 22.2 #2143
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #2143 +/- ##
==========================================
+ Coverage 84.31% 91.70% +7.38%
==========================================
Files 130 99 -31
Lines 15293 11017 -4276
Branches 2167 2167
==========================================
- Hits 12895 10103 -2792
+ Misses 2095 611 -1484
Partials 303 303
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Build succeeded - see https://readthedocs.org/projects/sourmash/builds/17522357/! 🎉 @sourmash-bio/devs ready for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
thanks! |
This PR fixes #2139.
In brief, docs building failed on readthedocs immediately after pip 22.2 was released. It looks very similar to pypa/pip#11294 which is caused by some underlying distutils interaction.
The fix is to ask the conda environment for docs building to use python=3.10, in
doc/environment.yml
.This PR also adds
pip
to thedoc/environment.yml
file per this message in the readthedocs build -