-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Fix sourmash prefetch
to work when db scaled is larger than query scaled
#1870
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1870 +/- ##
==========================================
+ Coverage 82.37% 90.35% +7.98%
==========================================
Files 119 89 -30
Lines 12935 8742 -4193
Branches 1727 1729 +2
==========================================
- Hits 10655 7899 -2756
+ Misses 2016 579 -1437
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sourmash prefetch
to work when db scaled is larger than query scaledsourmash prefetch
to work when db scaled is larger than query scaled
…o fix/prefetch_scaled_db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple minor things, otherwise lgtm!
Co-authored-by: Tessa Pierce Ward <[email protected]>
This PR fixes a problem where
sourmash prefetch
fails to properly downsample the query sketch as needed.TODO: