-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update lca summarize output to output total counts #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1838 +/- ##
==========================================
+ Coverage 81.92% 89.94% +8.02%
==========================================
Files 118 88 -30
Lines 12783 8592 -4191
Branches 1705 1705
==========================================
- Hits 10472 7728 -2744
+ Misses 2047 600 -1447
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Ready for review and merge @sourmash-bio/devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the test case output, the counts
column equals to the total_counts
I am not sure if this test case validates the total_count
when it's different than the count.
thanks @mr-eyes - added a new test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you.
thank you! |
This PR adds a
total_counts
column to the CSV output ofsourmash lca summarize
per #1833.Addresses most of #1833.