Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Clean up clippy lints from 1.52 #1505

Merged
merged 2 commits into from
May 7, 2021
Merged

[MRG] Clean up clippy lints from 1.52 #1505

merged 2 commits into from
May 7, 2021

Conversation

luizirber
Copy link
Member

New Rust release, new clippy recommendations =]

Also updates CI for nix to use nix-portable and better caching to lower runtimes.

@luizirber luizirber force-pushed the nix_clippy_updates branch from 7051875 to 03f60bd Compare May 7, 2021 17:25
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1505 (03f60bd) into latest (d57127b) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1505      +/-   ##
==========================================
- Coverage   89.88%   89.81%   -0.07%     
==========================================
  Files         124      124              
  Lines       19889    19888       -1     
  Branches     1515     1515              
==========================================
- Hits        17877    17863      -14     
- Misses       1783     1796      +13     
  Partials      229      229              
Flag Coverage Δ
python 94.93% <ø> (ø)
rust 66.84% <88.88%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/sketch/minhash.rs 90.51% <75.00%> (-0.81%) ⬇️
src/core/src/from.rs 100.00% <100.00%> (ø)
src/core/src/sketch/hyperloglog/mod.rs 81.76% <100.00%> (ø)
src/core/src/sketch/nodegraph.rs 83.87% <100.00%> (ø)
src/core/src/signature.rs 58.18% <0.00%> (-1.22%) ⬇️
src/core/src/index/sbt/mod.rs 66.15% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57127b...03f60bd. Read the comment docs.

@luizirber luizirber merged commit c923abe into latest May 7, 2021
@luizirber luizirber deleted the nix_clippy_updates branch May 7, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant