-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Adjust Index.find
search protocol to support selective collection of matches
#1477
Conversation
…o refactor/index_find
Codecov Report
@@ Coverage Diff @@
## latest #1477 +/- ##
==========================================
+ Coverage 89.71% 94.89% +5.17%
==========================================
Files 123 96 -27
Lines 19464 15926 -3538
Branches 1483 1497 +14
==========================================
- Hits 17463 15113 -2350
+ Misses 1775 587 -1188
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Index.find
search protocol to support selective collection of matchesIndex.find
search protocol to support selective collection of matches
@bluegenes I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As preliminary functionality, this looks good to me!
This PR builds off of the new
Index.find
method andJaccardSearch
protocol in #1392 to provide selective collection of matches.In #1392, we introduced the following logic in
Index.find(...)
:and this PR changes the
collect(...)
method so that it takes the match and can decide whether or not to continue:This permits the
collect(...)
method onJaccardSearch
objects to inspect the potential match and potentially decide to reject it. In turn, this enables signature "masking" functionality potentially useful for #849 and #985.Ref #1392 (comment)
cc @bluegenes