[MRG] refactor MinHash.downsample #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1458 +/- ##
==========================================
+ Coverage 89.45% 94.58% +5.13%
==========================================
Files 123 96 -27
Lines 19131 15518 -3613
Branches 1474 1475 +1
==========================================
- Hits 17114 14678 -2436
+ Misses 1784 606 -1178
- Partials 233 234 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started writing a guide to testing in sourmash, and I was using #1448 as an example and then I realized that the code was terrible. So I decided to refactor it before using it as an example 😆 .
This PR makes the guards in
MinHash.downsample(...)much clearer and more explicit, and adds some docs.Please wait for tests to pass before merging as I want to see the code coverage to make sure I got all the branches!