Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] comments update for ZipFileLinearIndex #1442

Merged
merged 97 commits into from
Apr 4, 2021
Merged

[MRG] comments update for ZipFileLinearIndex #1442

merged 97 commits into from
Apr 4, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 3, 2021

argh, forgot to push this change before merging #1349. So now it's a new PR.

This PR adds a comment to a confusing section of the signature loading code in ZipFileLinearIndex.signatures(...).

ctb added 30 commits February 25, 2021 07:09
ctb and others added 26 commits March 30, 2021 06:26
Co-authored-by: Tessa Pierce <[email protected]>
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #1442 (7adf978) into latest (beb3d59) will increase coverage by 5.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1442      +/-   ##
==========================================
+ Coverage   89.44%   94.59%   +5.14%     
==========================================
  Files         123       96      -27     
  Lines       19105    15491    -3614     
  Branches     1471     1471              
==========================================
- Hits        17089    14654    -2435     
+ Misses       1784      605    -1179     
  Partials      232      232              
Flag Coverage Δ
python 94.59% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/index.py 92.10% <ø> (ø)
src/core/src/ffi/minhash.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/wasm.rs
src/core/src/cmd.rs
src/core/src/ffi/signature.rs
src/core/src/ffi/cmd/compute.rs
src/core/tests/test.rs
src/core/src/ffi/utils.rs
src/core/src/index/bigsi.rs
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb3d59...7adf978. Read the comment docs.

@ctb ctb merged commit c49a8d8 into latest Apr 4, 2021
@ctb ctb deleted the doc/zipfile_index branch April 4, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants