-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] comments update for ZipFileLinearIndex
#1442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tessa Pierce <[email protected]>
Codecov Report
@@ Coverage Diff @@
## latest #1442 +/- ##
==========================================
+ Coverage 89.44% 94.59% +5.14%
==========================================
Files 123 96 -27
Lines 19105 15491 -3614
Branches 1471 1471
==========================================
- Hits 17089 14654 -2435
+ Misses 1784 605 -1179
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
bluegenes
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argh, forgot to push this change before merging #1349. So now it's a new PR.
This PR adds a comment to a confusing section of the signature loading code in
ZipFileLinearIndex.signatures(...)
.