-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use a Nodegraph for searching in internal nodes #1138
Conversation
|
Codecov Report
@@ Coverage Diff @@
## remove_min_n_below #1138 +/- ##
======================================================
- Coverage 89.39% 89.26% -0.14%
======================================================
Files 122 122
Lines 19001 19044 +43
Branches 1448 1451 +3
======================================================
+ Hits 16986 16999 +13
- Misses 1796 1827 +31
+ Partials 219 218 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
884454c
to
c119765
Compare
5c18d7b
to
b5db252
Compare
299bb38
to
78ab059
Compare
b5db252
to
85f707f
Compare
78ab059
to
c13ba85
Compare
curious if the changes in #1392 help or hurt this effort. (I don't like all of the function/class names in that PR, but it does some nice code cleanup and consolidation so I plan to propose it for merge in a few weeks.) |
85f707f
to
a689d17
Compare
use get_bf use containment directly bench and update containment create new function for intersection and union size keep doing it inplace... wip simdeez remove simd
turns out I was doing |
c13ba85
to
9531a23
Compare
7cbc764
to
cf61c97
Compare
Not focusing on SBTs anymore |
Updated version of #395, fixes #203
This builds up on #1137 and uses a Nodegraph for querying internal nodes. It actually passes the test currently failing in #1137, so I'm starting to think there is something fishy going on with
node.data.matches(mh)
...TODO:
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?