Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Minor updates to release procedure #1102

Merged
merged 6 commits into from
Jul 14, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 14, 2020

Updates to release procedure based on following release notes for v3.4.0 (#1100):

  • replace ssh url with origin
  • note travis build generates artifacts
  • rust install / update instructions
  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Jul 14, 2020

Ready for review & merge @luizirber

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #1102 into master will increase coverage by 9.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
+ Coverage   83.86%   92.89%   +9.03%     
==========================================
  Files          98       74      -24     
  Lines        9108     5726    -3382     
==========================================
- Hits         7638     5319    -2319     
+ Misses       1470      407    -1063     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
sourmash/signature.py 92.85% <0.00%> (-0.27%) ⬇️
sourmash/_minhash.py 94.82% <0.00%> (-0.26%) ⬇️
sourmash/command_compute.py 97.44% <0.00%> (-0.20%) ⬇️
sourmash/sbtmh.py 89.71% <0.00%> (-0.19%) ⬇️
sourmash/nodegraph.py 93.57% <0.00%> (-0.18%) ⬇️
sourmash/sbt_storage.py 92.00% <0.00%> (-0.12%) ⬇️
sourmash/index.py 97.61% <0.00%> (-0.09%) ⬇️
sourmash/sbt.py 88.79% <0.00%> (-0.07%) ⬇️
sourmash/lca/lca_db.py 97.17% <0.00%> (-0.05%) ⬇️
sourmash/cli/__init__.py 98.90% <0.00%> (-0.02%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2872aa5...26974e1. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jul 14, 2020

hmm, may want to add conda-forge instructions to this. not sure how conda-forge handles updates!

@luizirber
Copy link
Member

I added conda-forge instructions and announcement tweets for 3.3.0 and 3.4.0

@luizirber luizirber force-pushed the update_release_docs branch from 9dbeafb to 315ac4f Compare July 14, 2020 22:07
@luizirber luizirber merged commit 1e0fff2 into master Jul 14, 2020
@luizirber luizirber deleted the update_release_docs branch July 14, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants