Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] improve lca index error message when inserting num signature #1076

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 3, 2020

LCA databases cannot be created with num signatures; while lca index does error out, it does so with an uninformative error about downsampling. This improves the lca index error message.

Fixes #1029
Fixes #462

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1076 into master will increase coverage by 9.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   83.63%   92.82%   +9.18%     
==========================================
  Files          99       74      -25     
  Lines        8996     5700    -3296     
==========================================
- Hits         7524     5291    -2233     
+ Misses       1472      409    -1063     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
sourmash/lca/command_index.py 93.22% <100.00%> (+0.71%) ⬆️
sourmash/lca/lca_db.py 96.29% <100.00%> (-0.90%) ⬇️
sourmash/sbt_storage.py 92.11% <0.00%> (-0.46%) ⬇️
sourmash/sig/__main__.py 92.94% <0.00%> (-0.44%) ⬇️
sourmash/sourmash_args.py 95.19% <0.00%> (-0.18%) ⬇️
src/core/src/wasm.rs
src/core/src/errors.rs
src/core/src/ffi/minhash.rs
src/core/src/sketch/ukhs.rs
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b846ffe...df03087. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jul 4, 2020

Ready for review & merge

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctb
Copy link
Contributor Author

ctb commented Jul 13, 2020

thanks!

@ctb ctb merged commit ec24ea1 into master Jul 13, 2020
@ctb ctb deleted the improve_lca_index_errmsg branch July 13, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants