-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Bunch of Rust refactors #1058
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
+ Coverage 83.94% 93.29% +9.34%
==========================================
Files 99 74 -25
Lines 9065 5963 -3102
==========================================
- Hits 7610 5563 -2047
+ Misses 1455 400 -1055
Continue to review full report at Codecov.
|
997a5e0
to
e03d2e9
Compare
e03d2e9
to
58bbaac
Compare
reuse buffer for md5sum, and add a method for resetting it iter_mins method for KmerMinHash
set up test infra for wasm, expose ComputeParameters to js
14c56da
to
6651c42
Compare
Ready for review and merge @ctb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in the Python code or UX was changed, and I did a light skim of the Rust code 👍
(These were in 6 or 7 different branches here, so I'm making a grab bag)
failure
(deprecated) tothiserror
failure
around for now, until the.backtrace()
support is available. This is useful when debugging FFI.serde_derive
and use thederive
feature inserde
(small paper cut)nohash-hasher
crate instead of the copy-pastedNoHashHasher
fromfinch
.signature
andComputeParameters
).ComputeParameters
instead of exposing struct.TODO
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?