-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add signature cat
and signature split
commands to combine/split signature files
#1044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
+ Coverage 92.09% 92.55% +0.45%
==========================================
Files 72 74 +2
Lines 5454 5585 +131
==========================================
+ Hits 5023 5169 +146
+ Misses 431 416 -15
Continue to review full report at Codecov.
|
signature cat
command to combine multiple signature filessignature cat
and signature split
commands to combine/split signature files
I think this is ready for initial review @bluegenes @taylorreiter @luizirber -- the code is a bit ugly, but the functionality is really nice and already useful! |
signature cat
and signature split
commands to combine/split signature filessignature cat
and signature split
commands to combine/split signature files
Thinking about use cases for |
piping is currently in a separate issue, #1049. that's not to say we couldn't address it here but it's a chunk of extra work that I might not get to soon :) note that
although note that the implementation supports specifying the output file as one of the input files --
which I could add as a test... |
added in 084879c. so, once we get stdin working, you could do
which would meet your needs, I think? |
hadn't seen your issue on this! yep, that would definitely fit. Would def be nice to avoid writing an intermediate file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! excited to use :)
thanks! |
This PR adds a
cat
and asplit
command to the sig submodule, to concatenate and split collections of signatures. See this discussion for the original motivation.sourmash cat
sourmash split
sourmash sig split
andsourmash sig cat
#1048)make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?