This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
authz: expose metrics of authzFilter duration
#9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9264 +/- ##
==========================================
- Coverage 41.46% 41.36% -0.10%
==========================================
Files 1333 1324 -9
Lines 72296 71858 -438
Branches 6657 6603 -54
==========================================
- Hits 29974 29725 -249
+ Misses 39580 39391 -189
Partials 2742 2742 |
keegancsmith
approved these changes
Mar 24, 2020
| tr, ctx := trace.New(ctx, "authzFilter", "") | ||
| defer func() { | ||
| if err != nil { | ||
| took := time.Now().Sub(began).Seconds() | ||
| defer tr.Finish() |
There was a problem hiding this comment.
I just used the same pattern I did for tr.Finish() in another place. Seems working fine, is there a reason we don't want to use defer tr.Finish()?
There was a problem hiding this comment.
seems like an unnecessary defer since there is no early termination. However, it is correct. Was wondering if there was some other reason you changed the code I didn't spot, but lgtm
unknwon
added a commit
that referenced
this pull request
Mar 24, 2020
* Expose metrics of authzFilter duration * Use time.Since to calculate time took * Update CHANGELOG # Conflicts: # dev/Procfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a p95 panel for
authzFilterduration:Fixes #8612