This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
search: increase default indexed-search timeout to 10s #8720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
force-pushed
the
core/default-zoekt-timeout
branch
from
cb9bd91
to
1c2d83b
Compare
unknwon
approved these changes
Mar 2, 2020
tsenart
approved these changes
Mar 2, 2020
Previously zoekt would timeout after 3s by default. This is a very conservative time, but on an established instance is enough. However, we have had two new customers this week run into unstable result counts due to this timeout. They needed to tune there resource allocations to fix the underlying issue, but the user experience was poor and confusing. So we increase the timeout to make it clear that search is slow rather than broken. This new timeout is far greater than we expect zoekt to take. The reason we use this timeout is we would rather be slow than inaccurate. Additionally if a user opts in to some timeout settings, those override the default.
keegancsmith
force-pushed
the
core/default-zoekt-timeout
branch
from
1c2d83b
to
77ece2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #8720 +/- ##
=======================================
Coverage 40.78% 40.78%
=======================================
Files 1304 1304
Lines 70318 70318
Branches 6496 6496
=======================================
Hits 28676 28676
Misses 39009 39009
Partials 2633 2633
|
keegancsmith
added a commit
that referenced
this pull request
Mar 11, 2020
Previously zoekt would timeout after 3s by default. This is a very conservative time, but on an established instance is enough. However, we have had two new customers this week run into unstable result counts due to this timeout. They needed to tune there resource allocations to fix the underlying issue, but the user experience was poor and confusing. So we increase the timeout to make it clear that search is slow rather than broken. This new timeout is far greater than we expect zoekt to take. The reason we use this timeout is we would rather be slow than inaccurate. Additionally if a user opts in to some timeout settings, those override the default.
keegancsmith
added a commit
that referenced
this pull request
Mar 11, 2020
Previously zoekt would timeout after 3s by default. This is a very conservative time, but on an established instance is enough. However, we have had two new customers this week run into unstable result counts due to this timeout. They needed to tune there resource allocations to fix the underlying issue, but the user experience was poor and confusing. So we increase the timeout to make it clear that search is slow rather than broken. This new timeout is far greater than we expect zoekt to take. The reason we use this timeout is we would rather be slow than inaccurate. Additionally if a user opts in to some timeout settings, those override the default.
This was referenced Mar 11, 2020
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously zoekt would timeout after 3s by default. This is a very
conservative time, but on an established instance is enough. However, we have
had two new customers this week run into unstable result counts due to this
timeout. They needed to tune there resource allocations to fix the underlying
issue, but the user experience was poor and confusing. So we increase the
timeout to make it clear that search is slow rather than broken.
This new timeout is far greater than we expect zoekt to take. The reason we
use this timeout is we would rather be slow than inaccurate. Additionally if a
user opts in to some timeout settings, those override the default.