This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
feat(ci): install chromium via http_archive
#62683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to install chromium for playwright to use but it's a bit of a nightmare. Starting with just the most pressing problem: Bazel cannot handle runfiles with spaces in them. When we extract just the chromium executable as we did in this commit, playwright fails because it expects the supporting files to be present:
tl;dr: It's looking for files in the
chromium-darwin-arm64/chrome-mac/Chromium.app/Contents/MacOS/../Frameworks/Chromium Framework.framework/
dir and it doesn't exist (because we only copied over the executable.So then I copied over all of the files like this (which causes lots of it's own problems because we can't use
$(location ...)
any more) but even before then it fails because the path from above (Chromium Framework) has a space in it.Test plan
It will run in CI