This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[SG-33093] Enable accessibilityAudit on create-insights.test.ts sign-in.test.ts edit-search-insights.test.ts settings.test.ts
#33889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edit-search-insights.test.ts settings.test.ts
umpox
reviewed
Apr 14, 2022
client/web/src/enterprise/insights/pages/insights/creation/intro/cards/InsightCards.tsx
Outdated
Show resolved
Hide resolved
client/web/src/enterprise/insights/pages/insights/creation/intro/cards/InsightCards.tsx
Outdated
Show resolved
Hide resolved
umpox
approved these changes
Apr 20, 2022
client/web/src/enterprise/insights/pages/insights/creation/intro/cards/InsightCards.tsx
Outdated
Show resolved
Hide resolved
…ro/cards/InsightCards.tsx Co-authored-by: Tom Ross <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled accessibility audit on
create-insights.test.tssign-in.test.tsedit-search-insights.test.tssettings.test.tsRefs
SG Issue
Gitstart Ticket
Test plan
Run the integration test
yarn test-integration:base client/web/src/integration/create-insights.test.tsyarn test-integration:base client/web/src/integration/sign-in.test.tsyarn test-integration:base client/web/src/integration/edit-search-insights.test.tsyarn test-integration:base client/web/src/integration/settings.test.tsSuccess criteria
accessibilityAuditenabledApp preview:
Check out the client app preview documentation to learn more.