Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Standalone dev server: Use HTTPS #25900

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Standalone dev server: Use HTTPS #25900

merged 7 commits into from
Oct 12, 2021

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Oct 11, 2021

Closes https://github.com/sourcegraph/sourcegraph/issues/21869

  1. Runs caddy alongside web-standalone
  2. web-standalone starts up on http://localhost:3080
  3. Caddy server starts up on https://sourcegraph.test:3443 with a trusted cert
  4. We reverse-proxy client responses from localhost:3080 to the Caddy server

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2021
@github-actions github-actions bot added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Oct 11, 2021
umpox
umpox commented Oct 11, 2021
View reviewed changes
sg.config.yaml Show resolved Hide resolved
@umpox umpox marked this pull request as ready for review October 11, 2021 14:06
@umpox umpox requested review from valerybugakov, eseliger and a team October 11, 2021 14:09
eseliger
eseliger approved these changes Oct 11, 2021
View reviewed changes
sg.config.yaml Outdated Show resolved Hide resolved
valerybugakov
valerybugakov approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great lightweight solution! Thanks for looking into it.

client/web/README.md Outdated Show resolved Hide resolved
client/web/dev/server/production.server.ts Outdated Show resolved Hide resolved
sg.config.yaml Outdated Show resolved Hide resolved
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Oct 12, 2021 •
edited
Loading

Notifying subscribers in CODENOTIFY files for diff beb5df1...afd8987.

Notify File(s)
@christinaforney doc/dev/background-information/web/web_app.md

@umpox umpox merged commit bcea2e2 into main Oct 12, 2021
@umpox umpox deleted the tr/https-dev-server branch October 12, 2021 10:44
@umpox umpox added the UI performance Improvements to the actual page rendering performance as well as perceived performance. label Nov 4, 2021
This was referenced Nov 4, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valerybugakov valerybugakov valerybugakov approved these changes

@eseliger eseliger eseliger approved these changes

Assignees
No one assigned
Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. UI performance Improvements to the actual page rendering performance as well as perceived performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HTTPS support to the web server
4 participants
@umpox @sourcegraph-bot @valerybugakov @eseliger