Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

monitoring: disable critical alerts banner by default #12155

Merged
merged 2 commits into from
Jul 14, 2020
Merged

monitoring: disable critical alerts banner by default #12155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20028a3
monitoring: disable critical alerts banner by default
bobheadxi Jul 14, 2020
e06c1a5
clarify feature
bobheadxi Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ All notable changes to Sourcegraph are documented in this file.
- PagerDuty notifiers: `severity` and `apiUrl`
- Webhook notifiers: `bearerToken`
- A new `disableSendResolved` option disables notifications for when alerts resolve themselves.
- Recently firing critical alerts are now displayed to admins in site alerts.
- Recently firing critical alerts can now displayed to admins via site alerts with the flag `alerts.hideObservabilitySiteAlerts` in user configuration.
bobheadxi marked this conversation as resolved.
Show resolved Hide resolved
- Specific alerts can now be silenced using `observability.silenceAlerts`. [#12087](https://github.com/sourcegraph/sourcegraph/pull/12087)
- Revisions listed in `experimentalFeatures.versionContext` will be indexed for faster searching. This is the first support towards indexing non-default branches. [#6728](https://github.com/sourcegraph/sourcegraph/issues/6728)

Expand Down
2 changes: 1 addition & 1 deletion schema/settings.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
"alerts.hideObservabilitySiteAlerts": {
"description": "Disables observability-related site alert banners.",
"type": "boolean",
"default": false
"default": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, but these default values are not respected they only act as documentation. This had no impact on the actual default behavior - you need to handle that at the location where you use this setting in code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still seeing this on sourcegraph.com because of this
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you fix this, make sure you cherry-pick the commit into the 3.18 branch so it gets into the release as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's unfortunate - thanks for catching that! https://github.com/sourcegraph/sourcegraph/pull/12189

},
"extensions": {
"description": "The Sourcegraph extensions to use. Enable an extension by adding a property `\"my/extension\": true` (where `my/extension` is the extension ID). Override a previously enabled extension and disable it by setting its value to `false`.",
Expand Down
2 changes: 1 addition & 1 deletion schema/settings_stringdata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.