Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

monitoring: grafana email notifier support #11554

Closed
wants to merge 25 commits into from

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Jun 17, 2020

Closes https://github.com/sourcegraph/sourcegraph/issues/11454

This PR adds:

  • email support for notifiers
  • automatic sync for SMTP settings from Sourcegraph site configuration

Implementation details:

  • map relevant parts of all site config to a GrafanaChange
  • changes now only have access to the new configuration (ie their goal is purely to apply incoming changes - this ties into my first question further down)
  • add new wrapper around the grafana client, GrafanaController, to also allow stop/restart capabilities

Questions:

@bobheadxi bobheadxi requested review from a team and slimsag June 17, 2020 05:26
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #11554 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11554   +/-   ##
=======================================
  Coverage   47.44%   47.44%           
=======================================
  Files        1404     1404           
  Lines       79706    79706           
  Branches     6816     6816           
=======================================
  Hits        37817    37817           
  Misses      38310    38310           
  Partials     3579     3579           
Flag Coverage Δ
#go 51.59% <0.00%> (ø)
#storybook 10.12% <0.00%> (ø)
#typescript 36.42% <0.00%> (ø)
#unit 47.04% <0.00%> (ø)

@unknwon
Copy link
Member

unknwon commented Jun 17, 2020

Is this ready for review? Seems still have many TODOs left. If not ready yet, suggest convert to draft :)

image

@bobheadxi
Copy link
Member Author

Ah good idea @unknwon sorry about that!

@bobheadxi bobheadxi marked this pull request as draft June 17, 2020 23:08
@bobheadxi bobheadxi removed the request for review from a team June 17, 2020 23:09
@bobheadxi bobheadxi mentioned this pull request Jun 18, 2020
37 tasks
@bobheadxi bobheadxi marked this pull request as ready for review June 18, 2020 03:55
@bobheadxi
Copy link
Member Author

Converting the draft for now due to change in plans: https://github.com/sourcegraph/sourcegraph/issues/11452#issuecomment-648652514 (will close when I have a new PR up)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitoring: automatically configure Alertmanager SMTP from site config
3 participants