Bump to the latest lsif-kotlin #371
Merged
+1,077
−1,077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the new signatures have "ERROR" because it's an Android library and we don't have the Android SDK on the classpath.
olafurpg
commented
Nov 22, 2021
| // ^^^^^^^^^ reference java/util/ArrayList#`<init>`(). | ||
| // ^^^^^^^^^^^^^ reference com/airbnb/epoxy/PoolReference# | ||
|
|
||
| @JvmOverloads | ||
| // ^^^^^^^^^^^^ reference kotlin/jvm/JvmOverloads#`<init>`(). | ||
| fun getPool( | ||
| // ^^^^^^^ definition com/airbnb/epoxy/ActivityRecyclerPool#getPool(). | ||
| // ^^^^^^^ definition com/airbnb/epoxy/ActivityRecyclerPool#getPool(). public final fun getPool(context: [ERROR : Context], poolFactory: () -> [ERROR : RecyclerView.RecycledViewPool]): com.airbnb.epoxy.PoolReference |
There was a problem hiding this comment.
FYI @Strum355 the Kotlin signature renderer uses "ERROR" when the code has compile errors. I'm not sure what the best behavior is, I personally prefer it like this over returning an empty string. It's easier to report a bug if the signature has "ERROR". This problem happens because the Android SDK is not on the classpath.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.