Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin staticcheck version to v0.2.2 #63

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

samherrmann
Copy link
Contributor

The CI pipeline has been broken in this project for some time because the latest version of staticcheck is not compatible with every version of Go. Through trial and error, it was discovered that staticcheck v0.2.2 is the latest version that is compatible with Go 1.16.

The authors of staticcheck also recommend pinning the version in CI pipelines to prevent unintentional breakage of the build [1].

References
[1]: https://staticcheck.io/docs/running-staticcheck/ci/github-actions/#version

The CI pipeline has been broken in this project for some time because
the latest version of staticcheck is not compatible with every version
of Go. Through trial and error, it was discovered that staticcheck
v0.2.2 is the latest version that is compatible with Go 1.16.

The authors of staticcheck also recommend pinning the version in CI
pipelines to prevent unintentional breakage of the build [1].

References
[1]: https://staticcheck.io/docs/running-staticcheck/ci/github-actions/#version
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My backlog.org file will be happy to be updated with a DONE for something I didn't do. Thank you so much :)

@keegancsmith keegancsmith merged commit 78a3d79 into sourcegraph:master Feb 3, 2023
@samherrmann
Copy link
Contributor Author

My backlog.org file will be happy to be updated with a DONE for something I didn't do. Thank you so much :)

You're welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants