Replace references to release guild with releases team #8891
Conversation
✅ Deploy Preview for sourcegraph-handbook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
craigfurman
force-pushed
the
releases-guild-to-team
branch
from
6d69c12
to
12de611
Compare
| release_guild: | ||
| title: Release Guild | ||
| leader: bolaji_olajide | ||
| leadership_sponsors: [quinn_slack] | ||
| members: | ||
| [ | ||
| joe_chen, | ||
| camden_cheek, | ||
| keegan_carruthers-smith, | ||
| mohammad_umer_alam, | ||
| bolaji_olajide, | ||
| warren_gifford, | ||
| jacob_pleiness, | ||
| ] |
There was a problem hiding this comment.
I noticed that there is this release_guild reference under data/guilds.yml (in fact it's the only element in that list). Following a chain of greps, that file appears to be used to replace the generator directive guild_roster:
handbook/src/lib/markdownToHtml.ts
Line 354 in 43ba32f
But, I can't find guild_roster anywhere else in the handbook. It looks like guilds are an unused feature of the handbook. I would ask the committer of the generator code but they appear to have left the company. If the release guild has indeed been replaced by the release team, we could remove this element? WDYT?
I didn't remove the guilds feature altogether, in case another guild wants to use it!
There was a problem hiding this comment.
Yeah we can remove this. I'm also unsure around what guild_roster is for as well 🤔
There was a problem hiding this comment.
This was likely used in the old release tool for some generated message or something. Missed in our deprecation efforts so far. Nice catch
|
Notifying subscribers in CODENOTIFY files for diff cf52e0b...953cbad.
|
* Replace slack channel references to discuss-release-ship with discuss-releases * Fix github team label for the releases team * Replace references to release guild with the releases team
craigfurman
force-pushed
the
releases-guild-to-team
branch
from
12de611
to
953cbad
Compare
Please holler if any of this is wrong! Some more notes in the self-review 👇