overlays: collect PVCs into a separate base #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this be a problem anyway because we specify the PVC in the volume definition of the Deployment? We might need to do something like kubernetes-sigs/kustomize#2037 |
|
it assumes the overlay the customer uses also replaces/edits the mention in the deployment |
pecigonzalo
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collects PVC resources into a separate base. this allows kustomizations to pick and choose which PVCs they want or avoid creating them altogether. we have customers that need this because they explicitly create PVs and map them to deployments/statefulsets with named claim refs.
(kustomize does not allow deletes)