Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay tests #4020

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add overlay tests #4020

wants to merge 7 commits into from

Conversation

caugustus-sourcegraph
Copy link
Contributor

Creates a new test suite based off the existing restricted tests and expands it to include other overlays. The suite creates a new GKE cluster (latest version) and reuses it for each overlay. My goal here was to stay close to the original test implementation and see where the sticking points were before changing too dramatically.

Not all overlays are tested. This is not yet hooked into CI because it's still a proof-of-concept and needs additional work. I've been successfully using it to verify local changes and it's even revealed a potential problem with the storage overlay.

Checklist

@@ -0,0 +1,44 @@
#!/usr/bin/env bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each overlay has its own test file that implements setup, deploy, verify and cleanup. This code is very similar between overlays and can be simplified.

@@ -0,0 +1,29 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,27 @@
apiVersion: policy/v1beta1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,9 @@
kind: StorageClass
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,26 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant