Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend pdb is missing matchLabels: for selector #355

Open
BadLiveware opened this issue Sep 29, 2023 · 0 comments · May be fixed by #476
Open

Frontend pdb is missing matchLabels: for selector #355

BadLiveware opened this issue Sep 29, 2023 · 0 comments · May be fixed by #476

Comments

@BadLiveware
Copy link

BadLiveware commented Sep 29, 2023

{{- if .Values.frontend.podDisruptionBudget }}
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: sourcegraph-frontend
spec:
{{- toYaml .Values.frontend.podDisruptionBudget | nindent 2 }}
selector:
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
app: sourcegraph-frontend
{{- end }}

This is missing matchLabels and should look like

 {{- if .Values.frontend.podDisruptionBudget }} 
 apiVersion: policy/v1 
 kind: PodDisruptionBudget 
 metadata: 
   name: sourcegraph-frontend 
 spec: 
   {{- toYaml .Values.frontend.podDisruptionBudget | nindent 2 }} 
   selector: 
     matchLabels: ## <<<
       {{- include "sourcegraph.selectorLabels" . | nindent 6 }} 
       app: sourcegraph-frontend 
 {{- end }} 
akurz added a commit to akurz/deploy-sourcegraph-helm that referenced this issue May 28, 2024
akurz added a commit to akurz/deploy-sourcegraph-helm that referenced this issue May 28, 2024
akurz added a commit to akurz/deploy-sourcegraph-helm that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant