fix(Blank Screen): Improve UTF-16 character handling in Typewriter class #5982
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Typewriter class, which provides the typing animation effect in chat responses, was not properly handling UTF-16 characters. This could lead to broken rendering of:
which resulted in a blank screen in the Cody chat.
Solution
Added proper UTF-16 character boundary handling by:
getNextValidSlicePoint
method that respects code point boundariesArray.from()
to properly handle UTF-16 code pointsDemo
Before fix:
Before_BlankScreen.mp4
After fix:
After_BlankScreen.mp4
Test plan
All tests were performed with the 'Temperature' setting equal to 0 (zero) to obtain deterministic results.
Notes
Changelog