Implement edit/insert prompts #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thenamankumar
commented
Oct 21, 2024
| @@ -177,7 +177,9 @@ function iconForContextItem(contextItem: SerializedContextItem): React.Component | |||
| ? SYMBOL_CONTEXT_MENTION_PROVIDER.id | |||
| : contextItem.type === 'repository' || contextItem.type === 'tree' | |||
| ? REMOTE_REPOSITORY_PROVIDER_URI | |||
| : contextItem.providerUri | |||
| : contextItem.type === 'openctx' | |||
There was a problem hiding this comment.
unrelated improvement.
thenamankumar
commented
Oct 21, 2024
| @@ -415,6 +415,7 @@ export interface Prompt { | |||
| description?: string | |||
| draft: boolean | |||
| autoSubmit?: boolean | |||
| mode?: PromptMode | |||
There was a problem hiding this comment.
the version for the api change is already handled in the code for the oct relase
vovakulikov
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/sourcegraph/issue/SRCH-1172/prompts-can-output-into-3-places
This PR integrates with the prompt mode (chat | edit | insert) from the SG API. Prompts with edit or insert mode are executed using the
executeEdit, the same way the commands are executed. The prompt is used as the instruction text forexecuteEdit. First the chat transcript is created, context is fetched and then theexecuteEditis called. TheFixupTaskfrom the execution is used to construct the response in chat. The response for now shows the diff only.In BG, the state for interactions mode is saved as intent. The dropdown and icon indicator for to allow users to manually change the mode and to see which mode is set, is only available behind the OneBox feature flag and will not be released yet.
Test plan
Changelog