Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Enable E2E v2 in CI #5952

Open
wants to merge 23 commits into
base: ci-enable-e2e-v2/windows-tweaks-1
Choose a base branch
from

Conversation

RXminuS
Copy link
Contributor

@RXminuS RXminuS commented Oct 20, 2024

Before E2Ev2 tests were not running as part of CI as to not introduce unnecessary warnings/errors whilst they still received some polish. Now that E2Ev2 tests have stabalized (and all remaining E2E tests have a upcoming migration PR) they are stable enough to run in CI.

Now we move all the current E2E tests to legacy (we might need to update the Required Merge Action Names) and enable E2Ev2 tests in CI.

Once all remaining tests have migrated (upcoming PR) we can make this new CI step required for merging.

Test plan

  • CI Should pass
  • Verify that reports show in Buildkite

Copy link
Contributor Author

RXminuS commented Oct 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RXminuS and the rest of your teammates on Graphite Graphite

@RXminuS RXminuS changed the title Add E2Ev2 in CI Testing: Enable E2E v2 in CI Oct 20, 2024
@RXminuS RXminuS marked this pull request as ready for review October 20, 2024 16:02
@RXminuS RXminuS changed the title Testing: Enable E2E v2 in CI E2E: Enable E2E v2 in CI Oct 20, 2024
@RXminuS RXminuS marked this pull request as draft October 21, 2024 12:58
@RXminuS RXminuS marked this pull request as ready for review October 21, 2024 16:08
@RXminuS RXminuS force-pushed the ci-enable-e2e-v2/windows-tweaks-1 branch from 276e91f to 71004fb Compare October 22, 2024 18:37
@RXminuS RXminuS force-pushed the rnauta/ci-enable-e2e-v2/enable-gh-ci branch from 7c9f76a to f935409 Compare October 22, 2024 18:37
@sourcegraph sourcegraph deleted a comment from github-actions bot Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

E2E Test - Summary

failed  4 failed
passed  50 passed

Details

report  Open report ↗︎
stats  54 tests across 9 suites
duration  4 minutes, 32 seconds
commit  e4d6843
info  Pipeline Summary

Failed tests

e2e › e2e/features/command-edit.test.ts › edit command › can change edit ranges
e2e › e2e/features/command-edit.test.ts › edit command › can change edit ranges
e2e › e2e/features/command-edit.test.ts › edit command › can change edit ranges
e2e › e2e/features/fixup-decorator.test.ts › fixup decorator › decorations from un-applied Cody changes appear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant