Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Grey chat window is back with vengeance #4431

Closed
Lebofly opened this issue Jun 3, 2024 · 2 comments · Fixed by #4459
Closed

bug: Grey chat window is back with vengeance #4431

Lebofly opened this issue Jun 3, 2024 · 2 comments · Fixed by #4459
Labels
bug Something isn't working clients/vscode cody

Comments

@Lebofly
Copy link

Lebofly commented Jun 3, 2024 •
edited by olafurpg
Loading

Version

v1.21.1717254953

Describe the bug

Very often the chat window will turn grey, it's happening after 10 minutes of use and occurs multiple times whether or not it's a new chat session. This is preventing me from further using Cody.

Expected behavior

No grey chat window

Additional context

image
@Lebofly Lebofly added bug Something isn't working clients/vscode labels Jun 3, 2024
@github-actions github-actions bot added the cody label Jun 3, 2024
@git-longcat
Copy link

I used v1.20.1 on Windows 11 for about an hour. The above problem occurred about 3 times.
On the other hand, I used v1.18.2 for several days, but this problem never occurred.

@dominiccooney Linear
Copy link
Contributor

That is probably the result of a WebView crash, for example OOM. The Chromium embedding API has a crash callback, we should find where VSCode surfaces that and trigger reloading the WebView. We should also add some Telemetry on this.

@sqs sqs mentioned this issue Jun 5, 2024
Merged
sqs added a commit that referenced this issue Jun 5, 2024
@sqs
fix memory leak in syntax highlighting (causing gray webviews)
c9ea58d 
rehype-highlight, the syntax highlighting lib we use, has a memory leak bug (remarkjs/react-markdown#791). Downgrading to rehype-highlight@^6.0.0 as recommended fixes the memory leak.

This was causing an issue where the Cody chat webview turned gray due to an out-of-memory situation.

- Fixes #4431
- Fixes https://linear.app/sourcegraph/issue/CODY-2062/gray-screen-in-chat
- Fixes https://linear.app/sourcegraph/issue/CODY-2017/reports-of-chat-ui-lagginess-on-long-messages
- Fixes https://community.sourcegraph.com/t/a-condensed-report-on-key-issues-affecting-cody/439#h-8-performance-issues-with-vscode-extension-18
@sqs sqs closed this as completed in #4459 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working clients/vscode cody
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix memory leak in syntax highlighting (causing gray webviews) sourcegraph/cody
3 participants
@dominiccooney @Lebofly @git-longcat