Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send good notification when the previously down service is helathy again #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

send good notification when the previously down service is helathy again #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions slack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

slack "github.com/ashwanthkumar/slack-go-webhook"
)

var notifications = make(map[string]int)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to the bottom of the file, with some whitespace around it, rather than crowding the unrelated comment on the line below.

// Slack consist of all the sub components required to use Slack API
type Slack struct {
Name string `json:"name"`
Expand All @@ -20,15 +20,17 @@ type Slack struct {
func (s Slack) Notify(results []Result) error {
for _, result := range results {
if !result.Healthy {
s.Send(result)
notifications[result.Title] = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using magic numbers, let's use a defined constant here.

s.Send(result, "danger")
} else if notifications[result.Title] == 1 {
notifications[result.Title] = 0
s.Send(result, "good")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, I wonder if the colors should be moved into constants as well.

}
}
return nil
}

// Send request via Slack API to create incident
func (s Slack) Send(result Result) error {
color := "danger"
func (s Slack) Send(result Result, color string) error {
attach := slack.Attachment{}
attach.AddField(slack.Field{Title: result.Title, Value: result.Endpoint})
attach.AddField(slack.Field{Title: "Status", Value: strings.ToUpper(fmt.Sprint(result.Status()))})
Expand Down