Adds Optional SQLite Docker #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealkevinard
force-pushed
the
docker-sql
branch
from
4d6b460 to
89eecf4
Compare
|
Hey, thanks for the contribution. Could you please just squash the commits so I have a better overview of the proposed change(s) over the multiple commits. |
therealkevinard
force-pushed
the
docker-sql
branch
from
89eecf4 to
e14c137
Compare
|
Of course! 👍 |
adds optional dockerfile and docker-compose with sqlite support/config. adds make target for alternate build. addresses sourcegraph#140
therealkevinard
force-pushed
the
docker-sql
branch
from
e14c137 to
3cd90aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows opt-in SQLite support with different build/run commands.
usage:
make docker_sqlitedocker-compose -f docker-compose.sqlite3.ymlThe d/c stack includes a separate worker, allowing its own entrypoint directive. eg:
checkup every 10s, independent of the frontend.A sqlite config.js is bind-mounted from
./statuspage/js/config_sqlite3.jsThe built docker image is larger: 155MB vs the fs-only image's 33.4 MB.
This is to address #140