Add additional information about internal services #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying subscribers in CODENOTIFY files for diff 54faef3...5f9537d.
|
55 tasks
bobheadxi
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Nice! I feel like we can probably include a link to https://about.sourcegraph.com/handbook/engineering/deployments as well here since a lot of that page is also internal services (internal sourcegraph instances)
|
Will do! |
|
@bobheadxi added, is that what you had in mind? |
|
Yep, LGTM - thanks! |
This was referenced Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/sourcegraph/sourcegraph/issues/13917
Some of the tooling where not described in our documentation, this adds a reference about them and a link to their definition.